[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28863 [Core Tor/Fallback Scripts]: updateFallbackDirs.py thinks it is python 3 compatible but it is not
#28863: updateFallbackDirs.py thinks it is python 3 compatible but it is not
---------------------------------------+-----------------------------------
Reporter: starlight | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor:
| 0.4.0.x-final
Component: Core Tor/Fallback Scripts | Version: Tor:
| 0.3.5.5-alpha
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: #28793 | Points:
Reviewer: | Sponsor:
---------------------------------------+-----------------------------------
Comment (by starlight):
Replying to [comment:2 teor]:
> Thanks for this patch.
>
> welcome
>
...
> Running the script over Tor was never supported, because the script is
designed to measure direct consensus download speeds.
Sure, but it runs nice anyway.
> I am not sure about the https change, the only https URL I can see is:
> {{{
> ONIONOO = 'https://onionoo.torproject.org/'
> }}}
this is where it happens; on searching found many folk adapting python 2
to 3 baffled by similar behaviors; didn't have time to dig deeper
>
> This URL validates fine in my (Tor) browser.
and with "torsocks openssl s_client -connect xxx", works fine
> I also see this note in the Python 2 urllib2 documentation:
> {{{
> Note The urllib2 module has been split across several modules in Python
3 named urllib.request and urllib.error. The 2to3 tool will automatically
adapt imports when converting your sources to Python 3.
> }}}
> https://docs.python.org/2/library/urllib2.html
>
> Is your patch missing the imports for python 3?
ran fine after the changes with python 3.7 (output at
https://lists.torproject.org/pipermail/tor-
relays/2018-December/016735.html); might work ok via direct but need
adjustment to function using torsocks, but out of scope as you say
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28863#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs