[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
 Reporter:  tom                                  |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,    |  Actual Points:
  035-removed-20180711, 040-roadmap-proposed     |
Parent ID:  #25925                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:45 juga]:
 > Replying to [comment:44 teor]:
 > [...]
 > > Please open pull requests for code questions and CI, even if the code
 doesn't work yet.
 >
 > is this a net-team preference or your personal preference?.

 It's common practice within the team.

 > I'm sorry that i learn about preferred working methods by try/error. I
 don't think this is documented anywhere and IRC questions don't work well
 with our timezones.

 That's ok, we are all still working out how we want to use GitHub.

 > > > i've left new comments after setting the compression state.
 > >
 > > I'm not sure how to find the new code, or the CI for that code.
 >
 > Sorry, there was not new code pushed to the branch, i thought it was
 possible to follow the comments without the code.
 > > When you ask questions, please open a pull request.
 >
 > ~~https://github.com/juga0/tor/commits/ticket21377_035_01_work~~
 > https://github.com/torproject/tor/pull/610
 >
 > Because it's the same branch, the previous comments/questions can be
 seen in the PR.
 >
 > Edit: link to the PR, not the branch

 Thanks!

 I think nickm's comments might be the cause of your issue: is the test
 actually running the compression code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs