[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28538 [Core Tor/Torsocks]: [regression] torsocks uses linux-specific tsocks_libc_accept4 on FreeBSD
#28538: [regression] torsocks uses linux-specific tsocks_libc_accept4 on FreeBSD
-------------------------------+------------------------------
Reporter: yurivict271 | Owner: dgoulet
Type: defect | Status: needs_review
Priority: Medium | Milestone:
Component: Core Tor/Torsocks | Version:
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------+------------------------------
Changes (by onirony):
* status: needs_information => needs_review
Comment:
@dgoulet
Neither your branch ''nor'' the current official torsocks source code can
even build on MacOS due, firstly, to {{{LIBC_ACCEPT4_NAME_STR);}}} in
torsocks.c, line 237. In addition, line 239 checks for
{{{tsocks_libc_accept4}}} which, of course, will not be defined on MacOS.
This can be easily fixed with the following patch for torsocks.c:
[https://github.com/seisvelas/torsocks/commit/e99d2dbd207e029e2a6a0469fcf36a771d120c25]
Using that patch I am able to build your branch as well as standard
torsocks on MacOS.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28538#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs