[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28938 [Core Tor]: Fix incorrect OpenBSD macro tests (fix testsuite failure)

#28938: Fix incorrect OpenBSD macro tests (fix testsuite failure)
----------------------+------------------------------
 Reporter:  kjak      |          Owner:  (none)
     Type:  defect    |         Status:  needs_review
 Priority:  Medium    |      Milestone:
Component:  Core Tor  |        Version:
 Severity:  Normal    |     Resolution:
 Keywords:            |  Actual Points:
Parent ID:            |         Points:
 Reviewer:            |        Sponsor:
----------------------+------------------------------

Comment (by kjak):

 I have tested using the branch `release-0.3.4` and the test suite ran
 fine, so the test suite failure does not seem to be present in 0.3.4.

 {{{
 =======================================
    tor 0.3.4.9-dev: ./test-suite.log
 =======================================

 # TOTAL: 19
 # PASS:  14
 # SKIP:  5
 # XFAIL: 0
 # FAIL:  0
 # XPASS: 0
 # ERROR: 0
 }}}

 I also tested using the tag `tor-0.3.5.4-alpha` and the same test suite
 failure that the PR fixes appears there as well, so this is not a brand-
 new failure in 0.3.5.

 {{{
 =========================================
    tor 0.3.5.4-alpha: ./test-suite.log
 =========================================

 # TOTAL: 20
 # PASS:  13
 # SKIP:  5
 # XFAIL: 0
 # FAIL:  2
 # XPASS: 0
 # ERROR: 0

 <snip>

 options/validate__transproxy: [forking]
   FAIL src/test/test_options.c:1163: assert(tdata)
   [validate__transproxy FAILED]

 <snip>
 }}}

 I have not done further builds to test, but from what I see I think this
 failure may have occurred since commit 6c440da9 which removed system
 headers (including `sys/param.h`) from `or.h`.  On the 0.3.4 branch
 `sys/param.h` is still included in `or.h`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28938#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs