[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4310 [Core Tor/Tor]: alphabetize torrc options within sections

#4310: alphabetize torrc options within sections
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  documentation tor-client manpage     |  Actual Points:
  easy                                           |
Parent ID:                                       |         Points:  3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by swati):

 I am sorry. My intention was to only re-rder man page entries. I didn't
 realize how in the process of copying and pasting, the whitespace changes
 emerged. I'll try to figure out how this happened. Should I close the PR
 and submit this again?

 Replying to [comment:12 teor]:
 > Hi swati,
 >
 > Replying to [comment:5 nickm]:
 > > If you want to submit a patch, please make sure that it does
 '''nothing else''' besides reorder the manpage entries; otherwise, it will
 be hard to review.
 >
 > This patch re-orders manpage entries, but it also makes whitespace
 changes, for example:
 > https://github.com/torproject/tor/pull/1567/files#diff-
 53a84e5af0d074614e6d722a25038cb7R277
 >
 > Some of these whitespace changes appear to be incorrect:
 > https://github.com/torproject/tor/pull/1567/files#diff-
 53a84e5af0d074614e6d722a25038cb7R283
 >
 > Please make a pull request that only re-orders manpage option entries,
 and doesn't make any other changes.
 >
 > If you are using git, all the changes should be highlighted as "moved"
 with `git diff --color-moved`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4310#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs