[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1074 [Tor Client]: Tor sends clock_skew status event warn too liberally

#1074: Tor sends clock_skew status event warn too liberally
-------------------------------+--------------------------------------------
  Reporter:  arma              |               Type:  defect    
    Status:  needs_review      |           Priority:  minor     
 Milestone:  Tor: unspecified  |          Component:  Tor Client
   Version:  0.2.1.19          |         Resolution:  None      
  Keywords:                    |             Parent:            
    Points:                    |   Actualpointsdone:            
Pointsdone:                    |       Actualpoints:            
-------------------------------+--------------------------------------------

Comment(by Sebastian):

 Review comments:

 {{{
 +      const tor_addr_t trusted_dir_addr;
 +      tor_addr_from_ipv4n(&trusted_dir_addr, any_trusted_dir->addr);
 }}}
 You have to lose the const here (try compiling your code with --enable-
 gcc-warnings argument for configure)

 Generally the patch had me fooled a bit. A slightly changed version is in
 branch bug1074 in my repository. See
 https://gitweb.torproject.org/sebastian/tor.git/shortlog/refs/heads/bug1074
 and
 https://gitweb.torproject.org/sebastian/tor.git/commitdiff/34008d860e3c385128148bdb619fa4fd1322369e

 Also more nitpicking: please wrap your commit messages too, that makes
 them easier to read with the normal git tools

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1074#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs