[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4282 [Tor]: Extract common "make private stats dir" code from rephist.c, geoip.c

#4282: Extract common "make private stats dir" code from rephist.c, geoip.c
----------------------------------------+-----------------------------------
 Reporter:  nickm                       |          Owner:                    
     Type:  defect                      |         Status:  needs_review      
 Priority:  normal                      |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                         |        Version:                    
 Keywords:  easy refactoring tor-relay  |         Parent:                    
   Points:                              |   Actualpoints:                    
----------------------------------------+-----------------------------------

Comment(by nickm):

 Replying to [comment:6 piet]:
 > I fixed the indentations in my patch to match the conventions.

 Thanks!

 > (Btw, is there a documentation of the code conventions somewhere?)

 What there is, is in doc/HACKING in the Tor source code.  I'm not sure how
 complete it is though.

 > I also tried to come up with some meaningful unit tests for both of the
 new functions.

 Thanks!

 I hope to review this again and merge it once 0.2.5 has its own branch --
 hopefully some time this month.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4282#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs