[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10841 [Tor]: Remove hidden service version 0 directory code

#10841: Remove hidden service version 0 directory code
-----------------------------+--------------------------------
     Reporter:  karsten      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  minor        |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:4 nickm]:
 > Did you mean needs_revision or needs_review?

 Yes, needs_review.  Oops.

 > Notes while reviewing:
 >  * I'm surprised to see DIR_PURPOSE_FETCH_RENDDESC and
 DIR_PURPOSE_UPLOAD_RENDDESC disappear.  I guess they were v0 only. (Next
 time we add a v1 or a v2, we should make sure that we rename the old
 functions to "*_v0", so that we don't get confused this way again.)

 Correct, those two were only used for v0.

 >  * I wondered about removing the "case -1" case from
 connection_dir_client_reached_eof.  I guess that return value shouldn't
 happen anymore.... but having these semi-enumerated error codes makes me
 twitchy.  Maybe we should be using an enum for these.  I guess that's
 another commit.  I can do that one if you like.

 Okay.  Do you mind making that change to an enum?

 >  * Do we still need rend_parse_service_descriptor?  I think you may have
 removed the only thing that called it.

 True!  Please find my updated branch bug10841.

 I wonder, is there a simple way to find unused functions in tor?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10841#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs