[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #10169 [Tor]: Extend OOM handler to cover channels/connection buffers

#10169: Extend OOM handler to cover channels/connection buffers
------------------------+----------------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  major   |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay oom 024-backport
Actual Points:          |  Parent ID:
       Points:          |
------------------------+----------------------------------------

Comment (by andrea):

 Code review for NickM's bug10169_023 branch:

 https://gitweb.torproject.org/nickm/tor.git/shortlog/refs/heads/bug10169_023
 91ec6f7269bd7a5b73629f38e9779e84a0fb84f2..79c234e0e3fa22d76029bd3b5e2c52072709cff3

 91ec6f7269bd7a5b73629f38e9779e84a0fb84f2:
  - I don't like the name buf_get_oldest_chunk_timestamp() for a function
 that
    returns an age rather than a timestamp.
  - Can anything horrible happen with all this if the clock gets reset?
    - Perhaps it would be wise to use clock_gettime(CLOCK_MONOTONIC, ...)
 where
      available if we aren't doing so already.
  - The adjustment in chunk_grow() is wrong but you fixed it
    in 79515917449c7e0d92f16db0d1e5af4a0370bbab

 eabcab2b7caab75ba8607c7dac225e4533998e80:
  - This looks okay to me.

 a406f6d0f05f812ced4bfc048f30bc8692be7e93:
  - This looks okay to me.

 03ff21b018c8d0b005d2a60c3ba2bf08d6cb00bb:
  - This looks okay to me.

 e572ec856dff263d7f43ec6d42fe3fc3b7557f73:
  - This looks okay to me.

 647248729fa65f0e51d062e2af8f4e8b38592bf5:
  - This looks okay to me.

 79515917449c7e0d92f16db0d1e5af4a0370bbab:
  - This looks okay to me.

 fd28754dd3dce0e00304825d531348414c0a354b:
  - Yeah, this might be a good move :)

 79c234e0e3fa22d76029bd3b5e2c52072709cff3:
  - This looks okay to me.

 Code review for NickM's bug10169_024 branch:

 https://gitweb.torproject.org/nickm/tor.git/shortlog/refs/heads/bug10169_024

  - All of bug10169_023 plus merges:
    - 5c45a333c3cdfc4c7a817425a1c3ae88085c389b
    - 05d8111eedee9e11e4bb1c42e93ae2fc168d52ec

 5c45a333c3cdfc4c7a817425a1c3ae88085c389b:
  - This looks okay to me.

 05d8111eedee9e11e4bb1c42e93ae2fc168d52ec:
  - This looks okay to me.

 Code review for bug10169_025 branch:

 https://gitweb.torproject.org/nickm/tor.git/shortlog/refs/heads/bug10169_025_v2

  - All of bug10169_024 plus
 87fb1e324c1b3214765c46bec3d9ec6adc3fa83d..c8d41da52d6ae1edd1c4999e328b1e7eadc0ab5b

 87fb1e324c1b3214765c46bec3d9ec6adc3fa83d:
  - This looks okay to me.

 eb6f433bdbd6cf44e1f35272ed04a6c0e14f3c2d:
  - This looks okay to me.

 f425cf833852c4e1b4660cbba6190d04b070f6b6:
  - This looks okay to me.

 d379fc6e0ffce916753e5ef1ac0783703d150fa5:
  - This looks okay to me.

 52d222aafbc21d674624fdd4c8fc834a40af69c7:
  - This looks okay to me.

 9a07ec751ff73062b958a8fc9f8437bed72e144c:
  - This looks okay to me.

 48877e24a880be41e4dad50f5ebb6e0671e9f92f:
  - This looks okay to me.

 c8d41da52d6ae1edd1c4999e328b1e7eadc0ab5b:
  - This looks okay to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10169#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs