Re: [tor-bugs] #11015 [Obfsproxy]: UniformDH should not block the main event loop

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#11015: UniformDH should not block the main event loop
---------------------------+-----------------------------------------------
     Reporter:  yawning    |      Owner:  asn
         Type:  defect     |     Status:  new
     Priority:  normal     |  Milestone:
    Component:  Obfsproxy  |    Version:
   Resolution:             |   Keywords:  python, UniformDH, cpu exhaustion
Actual Points:             |  Parent ID:
       Points:             |
---------------------------+-----------------------------------------------

Comment (by infinity0):

 LGTM, with the following suggestions:

 - move the errback next to the callback so they are visually closer
 together
 - self.circuit.close() is only called when you trap ValueError; it is not
 called if the error is something else (in which case trap() raises).
 perhaps you should move it above the trap.
 - you may want to log e as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11015#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs