[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11048 [Tor]: Thread-safety in log_backtrace()

#11048: Thread-safety in log_backtrace()
------------------------+--------------------------------
     Reporter:  nickm   |      Owner:
         Type:  defect  |     Status:  needs_review
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:          |   Keywords:  tor-relay
Actual Points:          |  Parent ID:  #11046
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  new => needs_review


Comment:

 I've attached a patch and also uploaded it as branch "bug11048" to my
 public repo.


 I bet that using a lot of stack or using malloc is probably not too bad
 here, since this is assertion code, not signal handler code.  But I took
 the locking root, since we don't want two stack traces to get jumbled up
 together through multiple log_err() calls.  I hope I didn't mess it up.
 Please review?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11048#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs