[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8908 [Tor]: Tor systemd socket activation support

#8908: Tor systemd socket activation support
-----------------------------+--------------------------------
     Reporter:  cypherpunks  |      Owner:  intgr
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:  Tor: unspecified
   Resolution:               |   Keywords:  tor-relay systemd
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by misc):

 So looking at the patch (quickly), I have a few remark :
 - the use and inclusion of sd-daemon.c is deprecated. I would also
 recommend against bundling if possible.

 - in systemd_adopt_socket, why not use the sd_is_socket function ?

 - in connection_listener_new, why do you close the tor_close_socket if
 listen fail ( ie, this is not present in the original code, and that's
 already done in the cleanup label code, after the label 'err')

 Otherwise, that's quite a interesting approach ( comparing the exiting
 config with the systemd socket ), so I will take a bit more time to look
 in more details.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8908#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs