Re: [tor-bugs] #10884 [Tor]: Tor should print out the SHA-1 bridge fingerprint once that's more common as search string in Globe

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#10884: Tor should print out the SHA-1 bridge fingerprint once that's more common
as search string in Globe
-----------------------------+------------------------------
     Reporter:  karsten      |      Owner:  karsten
         Type:  enhancement  |     Status:  needs_revision
     Priority:  normal       |  Milestone:  Tor: unspecified
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:3 nickm]:
 >  * As usual, I'd be more comfortable with tor_asprintf() than
 tor_snprintf().

 Ah, I only moved code around.  But I'll try to remember to use
 tor_asprintf in the future when I write new code.  It does look cleaner.

 >  * I think the filename should be more like "hashed-fingerprint"?  Or if
 not, the state file documentation should explain why bridges do this.

 Actually, the new filename is "hashed-fingerprint".  Should we add another
 sentence to the state file documentation saying why bridges write this
 file?  How about "Bridge operators should use the hashed fingerprint to
 look up their bridge on Tor status websites, because the (non-hashed)
 fingerprint could be used to find out the bridge's IP address."  Or
 something shorter?  Or something in better English?

 >  * We can tighten the code there a little, and why not.

 Looks good!

 >  * Test test test.

 Did you forget to `git add src/test/test_routerkeys.c`?  Your branch
 doesn't compile for me.

 > I've tried banging on this as branch "bug10884".  If you like it, I'll
 merge it.

 From reading the code, I like it.  I can run some simple tests with `tor
 --list-fingerprint` once your branch compiles for me, either before or
 after you merge.

 As usual, thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10884#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs