Re: [tor-bugs] #10933 [Chutney]: support for setting binary paths via environment varaibles

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#10933: support for setting binary paths via environment varaibles
-----------------------------+--------------------
     Reporter:  dave2008     |      Owner:  nickm
         Type:  enhancement  |     Status:  closed
     Priority:  normal       |  Milestone:
    Component:  Chutney      |    Version:
   Resolution:  implemented  |   Keywords:
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------
Changes (by nickm):

 * status:  needs_revision => closed
 * resolution:   => implemented


Comment:

 Replying to [comment:4 dave2008]:
 > hi nick,
 >
 > sorry the the late reply, was out for travel :)
 >
 > I have updated my branch accordingly.

 > There is duplicate code mainly because subprocess is called with
 different arguments. maybe we should clean up that a little bit and make a
 wrapper for code reuse on the try/catch code?

 Hm. It's a little irksome, but I think it's not actually the end of the
 world here. I'd take a patch to remove the redundancy if you want to write
 one.

 In any case, this looks fine, so I merged it.

 BTW, I also changed `errno.errorcode[e.errno] == 'ENOENT' to `e.errno ==
 errno.ENOENT`, and made the log messages include the name of the binary
 that we tried to open.

 > Also should we switch to argparse module as well?

 The documentation says that module is new in Python 3.2.  I think we still
 have Chutney working with python 2.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10933#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs