[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14859 [Onionoo]: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new format

#14859: Adapt Onionoo's parsing code for MaxMind's GeoLite2 City files to their new
format
-------------------------+--------------------
     Reporter:  karsten  |      Owner:
         Type:  defect   |     Status:  closed
     Priority:  normal   |  Milestone:
    Component:  Onionoo  |    Version:
   Resolution:  fixed    |   Keywords:
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------
Changes (by karsten):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 I'm taking back my last comment above.  The bug described there exists,
 but I'd like to fix that bug differently.  However, the bug is more
 related to #13267, and I'd like to close this ticket now and discuss the
 issue over there.

 I went ahead and merged the following two commits into master, because
 there's not really much to review:

 {{{
 commit 9398d6999022b4d03a2305b8dbaf66bfd52801be
 Author: iwakeh <iwakeh@xxxxxxxxxxxxxxxxxxxx>
 Date:   Thu Jan 22 21:00:00 2015 +0000

     Do not proceed with lookup if an encoding error is reported and log
 file encoding errors.

 commit 2d8eb09d1e37af4efd1776acf73ff94b98ca8bbd
 Author: Karsten Loesing <karsten.loesing@xxxxxxx>
 Date:   Tue Feb 24 10:50:54 2015 +0100

     Fix character encoding of ASN database file.

     Looks like MaxMind's ASN database files are ISO-8859-1 encoded, not
 UTF-8
     encoded...
 }}}

 Resolving.  Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14859#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs