[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25127 [Core Tor/Tor]: Rust implementation of protover_get_supported_protocols() leaks memory

#25127: Rust implementation of protover_get_supported_protocols() leaks memory
----------------------------------+------------------------------------
 Reporter:  nickm                 |          Owner:  isis
     Type:  defect                |         Status:  needs_review
 Priority:  Medium                |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.3.2.1-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  rust, protover, leak  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:  SponsorM
----------------------------------+------------------------------------
Changes (by isis):

 * status:  assigned => needs_review
 * version:   => Tor: 0.3.2.1-alpha
 * sponsor:   => SponsorM


Comment:

 There's patches in my `bug25127`
 [https://gitweb.torproject.org/user/isis/tor.git/log/?h=bug25127 branch].
 I'm not sure if I like what I came up with though. It might be better to
 make a macro to add the null bytes, similar to the one catalyst linked to,
 but probably without the `as *const ::std::os::raw::c_char` part.
 Opinions?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25127#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs