[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25254 [Metrics/Website]: Replace the getPosition function in metrics-web's bootstrap JS from bootstrap 3.3.5

#25254: Replace the getPosition function in metrics-web's bootstrap JS from
bootstrap 3.3.5
-----------------------------+------------------------------
 Reporter:  irl              |          Owner:  irl
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:  #23518           |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by irl):

 * cc: metrics-team (added)
 * status:  accepted => needs_review


Comment:

 Please review my branch [[https://gitweb.torproject.org/user/irl/metrics-
 web.git/log/?h=task/25254|task/25254]].

 Where the getPosition function is defined, the innards of that function
 are replaced with the minimised innards of the getPosition function from
 the 3.3.5 release. There are no references to minimised variables that
 were not defined in the function (at least as far as I could follow it).

 I've tested this out with Relay Search and it works as expected.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25254#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs