[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #20549 [Metrics/CollecTor]: Implement SanitizedBridgeServerDescriptor class that encapsulates the sanitizing logic for bridge server descriptors

#20549: Implement SanitizedBridgeServerDescriptor class that encapsulates the
sanitizing logic for bridge server descriptors
-------------------------------+------------------------------
 Reporter:  iwakeh             |          Owner:  metrics-team
     Type:  enhancement        |         Status:  needs_review
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  metrics-2018       |  Actual Points:
Parent ID:  #20542             |         Points:
 Reviewer:  iwakeh             |        Sponsor:
-------------------------------+------------------------------

Comment (by iwakeh):

 This s a different approach from the tickets description.  But, I really
 like this idea and added seven more commits.  The commit comments should
 describe the details, if necessary.  The general changes are some name
 changes, like introducing `DescriptorBuilder` as builder, which we might
 reuse elsewhere.
 The new `DescriptorBuilder` also accepts appending `DescriptorBuilder`
 now.

 Please review
 [https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-20549
 seven commits] on the task-20549 branch.

 Maybe, we should change the title and summary to a more general "Make
 bridge descriptor sanitization more maintainable and more modular"?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20549#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs