[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #29080 [Applications/Tor Browser]: Merge OrbotService and TOPL

#29080: Merge OrbotService and TOPL
-------------------------------------------------+-------------------------
 Reporter:  sisbell                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TBA-a3,                  |  Actual Points:
  TorBrowserTeam201902R                          |
Parent ID:  #27609                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:15 sisbell]:
 > Replying to [comment:14 sysrqb]:
 > > Shane, can you expand on why this is better?
 https://github.com/sisbell/tor-android-service/issues/12
 >
 > In tor-browser-build, we will replace these jars/libs with the ones that
 are generated as part of the build. The developer who wants to use tor-
 android-service in their own project will have these libraries already
 provided in the libs folder. This keeps a consistent approach. I'm still
 exploring whether these dependent libraries should be treated as provided,
 meaning they won't be packaged in the resulting aar.
 >
 > Ideally, in the future, I'd like to get the TOPL artifacts officially
 deployed to a maven repo and pull these down as dependencies during a
 regular developer build. The tor-browser-build would pull down the
 dependencies as part of the build process as well.


 Ah, so this is simply a stop-gap until they're available from a maven
 repo? That's fine. And if tor-browser-build will build these independently
 and (presumably) overwrite the vendored files, then I'm okay with that
 too, thanks for explaining.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29080#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs