[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #33144 [Circumvention/Snowflake]: Overhaul websocketconn.Conn; implement net.Conn
#33144: Overhaul websocketconn.Conn; implement net.Conn
-------------------------------------+------------------------
Reporter: dcf | Owner: dcf
Type: enhancement | Status: closed
Priority: Medium | Milestone:
Component: Circumvention/Snowflake | Version:
Severity: Normal | Resolution: fixed
Keywords: | Actual Points:
Parent ID: | Points:
Reviewer: cohosh | Sponsor:
-------------------------------------+------------------------
Changes (by dcf):
* status: merge_ready => closed
* resolution: => fixed
Comment:
Replying to [comment:4 cohosh]:
> Nice! This is a really clean implementation. Thanks for working on this.
>
> My only question is about the different write methods used in the tests
at
[https://gitweb.torproject.org/user/dcf/snowflake.git/tree/common/websocketconn/websocketconn_test.go?h=bug33144-websocketconn&id=4a13694eefc21a11a2a9df5a59bbfba90a9e38da#n173
L173] vs
[https://gitweb.torproject.org/user/dcf/snowflake.git/tree/common/websocketconn/websocketconn_test.go?h=bug33144-websocketconn&id=4a13694eefc21a11a2a9df5a59bbfba90a9e38da#n207
L207].
Good eye! That was an oversight. I
[https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=bug33144-websocketconn&id=8dfe47a1cad21dbad197e988f1bd032d724df42a
changed it] to use `fmt.Fprintf` in both places.
Squashed and merged the branch in [https://gitweb.torproject.org
/pluggable-
transports/snowflake.git/log/?id=256959ca6594dddd9fe5b012680b4f0235401cd9
256959ca6594dddd9fe5b012680b4f0235401cd9].
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33144#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs