[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4896 [Stem]: Chroot set up for stem
#4896: Chroot set up for stem
-------------------------+--------------------------------------------------
Reporter: gsathya | Owner: atagar
Type: enhancement | Status: new
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Changes (by gsathya):
* cc: gsathya.ceg@â (added)
Comment:
> > > Define a function strip(self, prefix) in ControlMessage.
> > >
> > From a coding point of view that does sound much nicer. However, it's
a bad idea to introduce testing code into the library. >>There was one
spot where I broke that rule (an override function for
"stem.util.system.call()") and I'm currently trying to >>remove >it...
> ~~Yeah got it. I don't like this much either.~~
Ok that was wrong. I need this for Idea-3.
So it's either monkey patching(Idea 1) vs introducing a strip() function
to stem.socket.[wiki:ControlMessage](Idea 3).
I think adding a strip() function is the lesser of two evils. I vote for
Idea 3.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4896#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs