[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8510 [Tor]: Add useful Hidden Service related events to the Tor control port

#8510: Add useful Hidden Service related events to the Tor control port
-------------------------+----------------------------------------------
     Reporter:  hellais  |      Owner:
         Type:  task     |     Status:  needs_revision
     Priority:  normal   |  Milestone:  Tor: unspecified
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-hs controller needs-proposal
Actual Points:           |  Parent ID:  #8993
       Points:           |
-------------------------+----------------------------------------------

Comment (by asn):

 Replying to [comment:32 dave2008]:
 > Agree. I am wondering where which file I should put the testcase in.
 >
 > Since node_describe_by_id is a generic router specific function, it
 obviously does not belong to test_hs.c. Is there any test module that is
 specifically for router related functions?

 Hm, there is no `test_router.c` indeed. And there doesn't seem to be a
 place with lots of router.c unittests either (`test_dir.c` contains a
 few).

 I would suggest making your own `test_router.c`. We will need to unit test
 the rest of the funcs at `router.c` at some point anyway... If you think
 that's a poor idea, maybe you can put the test in `test.c` or `test_hs.c`
 but it doesn't look very suiting...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8510#comment:33>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs