[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7555 [Tor]: MapAddress from FQDN to .onion fails because resolve requests for hidden services are not allowed.

#7555: MapAddress from FQDN to .onion fails because  resolve requests for hidden
services are not allowed.
-------------------------+-------------------------------------------------
     Reporter:  aagbsn   |      Owner:  nickm
         Type:           |     Status:  needs_review
  enhancement            |  Milestone:  Tor: 0.2.6.x-final
     Priority:  normal   |    Version:  Tor: unspecified
    Component:  Tor      |   Keywords:  tor-client, 025-triaged, nickm-
   Resolution:           |  patch, asn-review
Actual Points:           |  Parent ID:  #14192
       Points:           |
-------------------------+-------------------------------------------------

Comment (by asn):

 Replying to [comment:34 nickm]:
 > Okay, I've added about 2^7^ lines of new comments, and fixed #12459.
 Thoughts?

 Very helpful. Thanks for all the comments.

 As a nitpick, you added a comment that says `condigured` instead of
 `configured`. And you also added a comment saying `/* Is the 'if'
 necessary here?  ???? */` which might deserve an XXX or something.

 Also, just making sure about this diff:
 {{{
 -    if (0 != (rr.end_reason & END_STREAM_REASON_DONE))
 +    if (END_STREAM_REASON_DONE != (rr.end_reason &
 END_STREAM_REASON_MASK))
        return 0;
      else
        return -1;
    }
 }}}
 Do we want to return `0` when the `end_reason` includes
 `END_STREAM_REASON_DONE`, or do we want to return -1 in that case? The
 func doc does not specify.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7555#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs