[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #16322 [Tor Browser]: Use duckduckgo hidden service instead of clearnet one
#16322: Use duckduckgo hidden service instead of clearnet one
-------------------------------------------------+-------------------------
Reporter: cypherpunks | Owner: tbb-
Type: enhancement | team
Priority: Medium | Status:
Component: Tor Browser | needs_review
Severity: Normal | Milestone:
Keywords: tbb-usability, | Version:
TorBrowserTeam201601R, tbb-5.5 | Resolution:
Parent ID: | Actual Points:
Sponsor: | Points:
-------------------------------------------------+-------------------------
Changes (by gk):
* keywords: tbb-usability, TorBrowserTeam201601R => tbb-usability,
TorBrowserTeam201601R, tbb-5.5
* cc: mcs, brade (added)
Comment:
bug_16322_v3 (https://gitweb.torproject.org/user/gk/tor-
browser.git/commit/?h=bug_16322_v3&id=912db6de1e8851870434a948b8721cd2aebf11de)
has a slightly different patch for review. It turns out we had two DDG
search plugins in our tree, one added by Mozilla in
https://bugzilla.mozilla.org/show_bug.cgi?id=1061736. That one got loaded
earlier than our own which caused the breakage with JavaScript disabled.
Moreover, the Mozilla one tracked from where the user was searching by
adding a search parameter to the query. My patch gets rid both of that
feature and of the duplicate DDG .xml. And, yes, thanks to the patch by
the cypherpunk the URL gets set to the onion service.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16322#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs