Re: [tor-bugs] #21095 [Metrics/Onionoo]: Accept more values for the "order" parameter

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#21095: Accept more values for the "order" parameter
-----------------------------+------------------------------
 Reporter:  lukechilds       |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-help     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by iwakeh):

 Replying to [comment:18 karsten]:
 > Very quick response before running off for a few hours:
 >
 >  - Using constants for field names makes sense, though "ascending" and
 "descending" don't really belong there but rather in the `server` package.
 Still, starting such a `Fields` interface or enum in the `docs` package
 sound fine.

 The asc/des-fields are used by the comparators and should be in their
 package, maybe in a different interface, e.g., Order.java or the
 comparator class itself?

 >  - Separate comparator class makes sense, though I'm not sure whether it
 rather belongs in the `server` package than `docs`.

 The comparator class is only concerned with docs, the server package uses
 docs and their comparators. Thus, the comparator class should be in docs.

 >  - Changes like copyright updates or Java 7 changes should be done in
 separate commits and for the entire code base.

 Separate commits for these changes true (that's why I didn't call my
 branch patch).
 Copyright can be done via commandline and for all classes at the same
 time, agreed.
 The java 7 changes require more fine-grained code changes and could also
 be done whenever classes are touched anyway.  So, it's more a question of
 available time to do these at once or class by class.

 >
 > Feel free to hack on this, and I'll review it later.  Or I can start
 making changes myself this afternoon and ask you to review them
 afterwards.  Up to you.  Thanks!

 Having other high priority tasks at the moment, I could sneak that in next
 week at some point, if you don't get to it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21095#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs