[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17847 [Core Tor/Tor]: Unify router_pick_directory_server_impl and router_pick_trusteddirserver_impl
#17847: Unify router_pick_directory_server_impl and
router_pick_trusteddirserver_impl
----------------------------+------------------------------------
Reporter: teor | Owner:
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy, refactor | Actual Points:
Parent ID: | Points: 2
Reviewer: | Sponsor:
----------------------------+------------------------------------
Comment (by ahf):
Sorry for the delay, this month has been quite intense so far.
I've made a revised version of the patch, which is now split into two
patches, and can be found at:
https://gitlab.com/ahf/tor/commits/ahf/bugs/17847_2
I've removed all the whitespace changes, split the changes into two
isolated commits, removed the `SKIP_IF_ALREADY_DIR_FETCHING` macro from
the previous patch and instead generalised the function to support both of
the variants that was needed before.
I've removed the `SKIP_EXCLUDED` macro from the previous revision since I
do not believe it actually adds any simplification to the code, since the
body is just an increment and a `continue` statement.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17847#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs