[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21195 [Metrics/CollecTor]: wrong exit-list annotation

#21195: wrong exit-list annotation
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  defect             |         Status:  merge_ready
 Priority:  High               |      Milestone:  CollecTor 1.1.2
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------
Changes (by karsten):

 * status:  needs_review => merge_ready


Comment:

 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-21195&id=dcccaaabb2798cb927242a357883dcfc8e95b68e
 dcccaaa] looks good.

 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-21195&id=7752b6d73538140cd34daf2267cc470dcc30b155
 7752b6d] looks good.

 [https://gitweb.torproject.org/user/iwakeh/collector.git/commit/?h=task-21195&id=5bc248e0e546d7c23f150b18d4c4283a4e8ecc58
 5bc248e] looks good and works, though I have two tweaks:

 {{{
 @@ -2,7 +2,7 @@
  #
  #  Only for upgrading from 1.1.0 or 1.1.1!!!
  #
 -#  Script for correcting ext-list annotations.
 +#  Script for correcting exit-list annotations.
  #  See task-21195 for details.
  #  Replaces 'torperf' with 'tordnsel' in files
  #  and archives.
 @@ -36,7 +36,8 @@
      tar xf $ARC;
      fix $TEMP exit-list-$ym
      mv $ARC $ARC-old;
 -    tar --remove-files -cJf exit-list-$ym.tar.xz exit-list-$ym
 +    tar --remove-files -cf exit-list-$ym.tar exit-list-$ym
 +    xz -9e exit-list-$ym.tar
      mv $TEMP/exit-list-$ym.tar.xz $ARC
      echo "--> $ARC is done."
  done;
 }}}

 The idea is to use `xz -9e` just like we used that option when creating
 original tarballs.  Not that it matters much, but why not be consistent.

 Okay, how do we proceed?  Should I merge your commits (with the tweak) and
 put out 1.1.2?  And would you want to announce it when it's out?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21195#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs