[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21236 [Metrics/Metrics website]: Put a visualization of Tor Browser downloads and updates on the Metrics website

#21236: Put a visualization of Tor Browser downloads and updates on the Metrics
website
-------------------------------------+------------------------------
 Reporter:  karsten                  |          Owner:  karsten
     Type:  enhancement              |         Status:  needs_review
 Priority:  High                     |      Milestone:
Component:  Metrics/Metrics website  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:                           |        Sponsor:
-------------------------------------+------------------------------

Comment (by iwakeh):

 Replying to [comment:23 karsten]:
 > [snip]  But let's talk more about this in Berlin when we all still
 memorize this code. :)

 All fine, I understand the timing issue.

 >
 > What we should talk about though is the log-line matcher issue you
 describe above.  I believe there's no bug!  ....  What we ''can'' do is
 turn the fourth, unused capturing group into a non-capturing group (see
 [https://gitweb.torproject.org/karsten/metrics-
 web.git/commit/?h=task-21236-4&id=57edde652bbdf2fd1ff511921d184f66000b696a
 57edde6 in my task-21236-4 branch]).  But that's just a tweak, not a
 bugfix.  If I overlooked a bug here, please let me know!

 Thanks for the analysis!
 Maybe, the import was trapped on a huge fourth group? But, actually, if
 nothing showed up in your import logs, I would just keep the code that
 made the import.  There would be also a test missing if the tweak is to be
 added to the codebase.  (Those regex-issues are always troublesome.)

 >
 > [snip]
 > Alright, I'll merge and deploy later today (assuming that these trivial
 two changes don't require much review).  And I'll write a short
 announcement to tor-project@ that this graph now exists.  But I'll hold
 back the blog post until we have a more thorough analysis of this graph,
 per suggestion from yesterday's Vegas meeting.

 Sounds good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21236#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs