[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #25065 [Obfuscation/Pluggable transport]: goptlib doesn't allow optimistic SOCKS data
#25065: goptlib doesn't allow optimistic SOCKS data
-------------------------------------------------+----------------------
Reporter: dcf | Owner: dcf
Type: enhancement | Status: assigned
Priority: Medium | Milestone:
Component: Obfuscation/Pluggable transport | Version:
Severity: Minor | Keywords: goptlib
Actual Points: | Parent ID:
Points: | Reviewer:
Sponsor: |
-------------------------------------------------+----------------------
goptlib [https://gitweb.torproject.org/pluggable-
transports/goptlib.git/tree/socks.go?id=a3ad5df6c9e7dc8117f55958b4ce99bf1e0fe291#n203
wraps its socket] in a [https://golang.org/pkg/bufio/#ReadWriter
bufio.ReadWriter] while processing the SOCKS handshake. Before returning
the socket back to the application, [https://gitweb.torproject.org
/pluggable-
transports/goptlib.git/tree/socks.go?id=a3ad5df6c9e7dc8117f55958b4ce99bf1e0fe291#n437
it makes sure] there is no unread data sitting in the buffer (which would
otherwise be lost).
In #24432, we're trying to have Tor Browser use meek-client as a proxy
directly, not going through Tor. The problem (comment:19:ticket:24432) is
that Tor Browser has a special optimistic data SOCKS patch that causes it
to send data exactly where goptlib checks to make sure there isn't any.
A mild rewrite of goptlib's SOCKS code could eliminate the internal buffer
and enable Tor Browser's optimistic data.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25065>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs