[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25008 [Core Tor/Tor]: Call protocol_list_supports_protocol less often to save time and allocation

#25008: Call protocol_list_supports_protocol less often to save time and allocation
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  032-backport?, malloc, performance,  |  Actual Points:
  protover, review-group-31                      |
Parent ID:  #23777                               |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => needs_revision
 * reviewer:   => dgoulet


Comment:

 Oh hello wonderful patch! I very much like this! It adds a nice semantic
 to the code and optimize it at the same time.

 I may ask if we can get the documentation of which protocol version value
 each member of `protover_summary_flags_t` is for. For instance,
 `supports_ed25519_hs_intro` requires ` HSIntro=4` but half of them aren't
 documented. And easy map with the spec would rock.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25008#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs