[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28989 [Core Tor/Tor]: test_hs_service: CID 1442277: Resource leaks (RESOURCE_LEAK)

#28989: test_hs_service: CID 1442277:  Resource leaks  (RESOURCE_LEAK)
-----------------------------+------------------------------------
 Reporter:  asn              |          Owner:  (none)
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs coverity  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Left a couple of comments on the patch.  I think we need to call the
 cleanup code in the `done:` block, so that coverity sees that it is always
 called, regardless of whether the tests pass or fail.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28989#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs