[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #28995 [Core Tor/Tor]: Fix the IPv6 case of tor_ersatz_socketpair
#28995: Fix the IPv6 case of tor_ersatz_socketpair
--------------------------------+------------------------------------
Reporter: kjak | Owner: (none)
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.0.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.5.1-alpha
Severity: Normal | Resolution:
Keywords: 035-backport, ipv6 | Actual Points:
Parent ID: | Points:
Reviewer: | Sponsor:
--------------------------------+------------------------------------
Changes (by teor):
* keywords: 035-backport? => 035-backport, ipv6
* version: => Tor: 0.3.5.1-alpha
Comment:
Replying to [comment:2 nickm]:
> I wonder, is this worth backporting to 0.3.5, or should we just take it
in 0.4.0? I don't think we actually _call_ this function with AF_INET6
anywhere, so it might not be necessary to backport.
The family argument must be AF_UNIX. It is checked and ignored. Instead,
ersatz_domain is passed to get_local_listener().
It took me a while to work this out, because the function comments in
socketpair.c are missing or incomplete.
Maybe we should add function comments, using the tor_socketpair() comment
as a starting point?
https://github.com/torproject/tor/blob/701eaef980de4f7dbb5c31c4fee9b7e1e266d7a1/src/lib/net/socket.c#L450
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28995#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs