[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #10416 [Core Tor/Tor]: Tor won't start on Windows when path contains non-ascii characters
#10416: Tor won't start on Windows when path contains non-ascii characters
-------------------------------------------------+-------------------------
Reporter: iktsuarpok | Owner: (none)
Type: defect | Status: new
Priority: High | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version: Tor:
| 0.2.3.25
Severity: Normal | Resolution:
Keywords: tor-client, windows, unicode, win32 | Actual Points:
Parent ID: #25729 | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by gk):
Replying to [comment:37 cypherpunks2]:
> Simple detector for tor-launcher
> {{{
> diff --git a/src/components/tl-process.js b/src/components/tl-process.js
> index 3aa45e4..e12e523 100644
> --- a/src/components/tl-process.js
> +++ b/src/components/tl-process.js
> @@ -355,6 +355,7 @@ TorProcessService.prototype =
> mLastTorWarningPhase: null,
> mLastTorWarningReason: null,
> mDefaultPreferencesAreLoaded: false,
> + mWindowsCodePageWrong: false,
>
> // Private Methods
/////////////////////////////////////////////////////////
> _startTor: function(aForceDisableNetwork)
> @@ -510,6 +511,12 @@ TorProcessService.prototype =
> if (env.exists("PATH"))
> path += ";" + env.get("PATH");
> env.set("PATH", path);
> + var check = env.get("PATH");
> + if (path != check) {
> + this.mWindowsCodePageWrong = true;
> + var s =
TorLauncherUtil.getLocalizedString("wrong_windows_codepage")
> + this._notifyUserOfError(s, null,
this.kTorProcessDidNotStartTopic);
> + }
> }
>
> this.mTorProcessStatus = this.kStatusStarting;
> }}}
Thanks! I opened #29020 for a potential warning mechanism in Tor Launcher.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10416#comment:39>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs