[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
 Reporter:  tom                                  |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,    |  Actual Points:
  035-removed-20180711, 040-roadmap-proposed     |
Parent ID:  #25925                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:50 juga]:
 > Replying to [comment:49 teor]:
 > > > You think this is valid test and this can be merged?.
 > >
 > > As long as we can get stem 1.7, it seems like a good test.
 >
 > Hmm, i didn't mean to include the python code as a test in tor code,
 since the test in C already checks the header
 (https://github.com/torproject/tor/pull/468/files#diff-
 a63a60330b655aa123b096768848f5bfR2552), but to manually extra check that i
 can actually get the bandwidth file in a test network.
 > I currently don't know how it'd be possible to run a test network when
 running tor tests and include this code as an stem test.

 We don't need a test network, we just need a single tor instance.
 We have some tor integration tests already:
 https://gitweb.torproject.org/tor.git/tree/src/test/test_rebind.sh

 But we would need to configure the tor instance as a directory authority.
 So we would need to run tor-gencert to generate the authority keys. And
 require stem.

 Maybe the best place for this test is in stem?
 We could open a ticket for a stem integration test that tests bandwidth
 files.
 Do you think this test is worth adding? Will it catch future bugs?

 > So the question is then, is it fine the PR as it is?.

 I think the PR is ok without the test.
 But ahf still needs to review your changes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:51>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs