Re: [tor-bugs] #29166 [Metrics/Statistics]: Run modules from Java only

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#29166: Run modules from Java only
--------------------------------+------------------------------
 Reporter:  karsten             |          Owner:  karsten
     Type:  enhancement         |         Status:  needs_review
 Priority:  Medium              |      Milestone:
Component:  Metrics/Statistics  |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:                      |  Actual Points:
Parent ID:                      |         Points:
 Reviewer:  irl                 |        Sponsor:
--------------------------------+------------------------------

Comment (by notirl):

 {{{
 this.connection = DriverManager.getConnection(jdbcString);
 }}}

 Should this not still be explicitly `this.jdbcString`? It's still a class
 member and not a local variable.


 ----

 Some of the paths have been defined with `/` in them, which breaks
 compatibility with non-Unix operating systems. (Windows uses `\` and RISC
 OS uses `:` as examples.) I think we don't care but it's worth being aware
 of it.

 We should have a policy and be explicit about our use of, or avoidance of,
 java.nio.file.Paths.


 ----

 In general this looks OK, probably is best to not deploy it just before
 Brussels though. I can give it a more thorough review after Brussels.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29166#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs