[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #28614 [Core Tor/Tor]: Can't parse networkstatus consensus time

#28614: Can't parse networkstatus consensus time
-------------------------------------------------+-------------------------
 Reporter:  Vort                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  040-rc-must, regression,             |  Actual Points:
  postfreeze-ok, tbb-needs                       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Or maybe I am looking at this bug the wrong way around: how did it come to
 have \r's in it on disk? I assume it's because we wrote it with Windows-
 style O_TEXT which added the \r's. So if we want it to not have \r's in it
 when we read it, we need to write it in O_BINARY mode too? And then there
 will still be the edge case where we try to load a legacy file which has
 \r's in it, and we should teach ourselves to handle that case better (e.g.
 discard it and fetch another right then)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28614#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs