[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32907 [Core Tor/Tor]: Remove or_options_t dependencies from module config headers

#32907: Remove or_options_t dependencies from module config headers
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #32764        |         Points:  0.5
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Old description:

> The following inline header functions depend on some members of
> or_options_t, which is a dependency we don't need:
> * options_validate_dirauth_mode()
> * options_validate_server_transport()
> * options_validate_relay_mode()
> And the dependency only exists when the relay or dirauth modules are
> disabled.
>
> We could add stub C files that are only compiled when relay/dirauth mode
> is disabled.

New description:

 The following inline header functions depend on some members of
 or_options_t, which is a dependency we don't need:
 * options_validate_dirauth_mode()
 * options_validate_server_transport()
 * options_validate_relay_mode()
 And the dependency only exists when the relay or dirauth modules are
 disabled.

 Instead, we could put these functions in stub C files, which are only
 compiled when relay/dirauth mode is disabled.

--

Comment (by teor):

 Make description clearer.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32907#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs