[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32705 [Core Tor/Tor]: test_practracker.sh python issues
#32705: test_practracker.sh python issues
-------------------------------------------------+-------------------------
Reporter: nickm | Owner: teor
Type: defect | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-ci-fixed-fail jenkins python | Actual Points: 0.5
network-team-roadmap-2020Q1 043-should |
Parent ID: | Points: 0.1
Reviewer: dgoulet | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* actualpoints: 0.2 => 0.5
Comment:
Replying to [comment:16 catalyst]:
> Replying to [comment:15 nickm]:
> > Here is a small patch to never set TOR_DISABLE_PRACTRACKER in the
test:
> >
> > Branch: no_skip_test_practracker_042
> > PR: https://github.com/torproject/tor/pull/1658
> Looks reasonable at first glance. Maybe we should also make
practracker.py write a notice or warning to stderr when it exits early due
to TOR_DISABLE_PRACTRACKER, to make this sort of situation easier to
troubleshoot in the future?
I merged nickm's PR 1658 to 0.4.2 and later, and added catalyst's
suggested stderr notice.
I also fixed up my PR for master, which improves the practracker tests:
* master: https://github.com/torproject/tor/pull/1599
My PR makes the tests:
* capture stderr output (including exceptions)
* canonicalise paths, so that logged paths are the same, even in out-of-
tree builds
* fail the test if any process exits unexpectedly
* check the practracker exit status as part of the tests
I think dgoulet is right, and we shouldn't worry about Python 2 failures.
(Unless someone really wants to fix them.) I updated our supported
platforms policy to include Python:
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/SupportedPlatforms#Python
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32705#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs