Re: [tor-bugs] #33040 [Circumvention/Snowflake]: Minor Snowflake refactoring

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#33040: Minor Snowflake refactoring
-------------------------------------+-----------------------------
 Reporter:  dcf                      |          Owner:  dcf
     Type:  enhancement              |         Status:  merge_ready
 Priority:  Medium                   |      Milestone:
Component:  Circumvention/Snowflake  |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:                           |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  cohosh                   |        Sponsor:
-------------------------------------+-----------------------------
Changes (by cohosh):

 * status:  needs_review => merge_ready


Comment:

 These changes look good to me.

 Do we still need a check for a nil BrokerChannel that was removed in
 [https://gitweb.torproject.org/user/dcf/snowflake.git/commit/?h=bug33040-refactor&id=84e9b0626c1eb3de2f97af7379c973413f6b476d
 this commit]? It looks like `NewBrokerChannel` can return `nil` on error.
 In this case that seems to be if `brokerURL` isn't properly formatted.
 Perhaps an error check and log message in `client/snowflake.go` on the
 return of that function?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33040#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs