Re: [tor-bugs] #3578 [Pluggable transport]: 180-pluggable-transport.txt changes

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#3578: 180-pluggable-transport.txt changes
---------------------------------+------------------------------------------
 Reporter:  asn                  |          Owner:  asn         
     Type:  defect               |         Status:  needs_review
 Priority:  normal               |      Milestone:              
Component:  Pluggable transport  |        Version:              
 Keywords:                       |         Parent:              
   Points:                       |   Actualpoints:              
---------------------------------+------------------------------------------

Comment(by asn):

 Replying to [comment:2 nickm]:
 > Dropping the "proxy" in you
 > {{{
 > -     ServerTransportPlugin method proxy address:port param=val..
 > +     ServerTransportPlugin <method> <address:port> <param=val> ...
 > }}}
 > seems to serve no real purpose.
 >

 Oh, I thought that 'proxy' was just forgotten there from the
 ClientTransportPlugin line, and that we would distinguish between managed
 and external proxy lines by testing for '.' and ':' like we distinguish
 old-style and new-style Bridge lines.
 I guess I'll leave 'proxy' there then.
 >
 > Why did you change the addr:portnum stuff EXTENDED_SERVER_PORT, ORPORT,
 to be just "Port"?  That also seems needless.
 >

 I'm not sure; I was probably driven away by the FOO_PORT name.

 Do pull again for a second revision with the above issues fixed.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3578#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs