[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #6177 [Tor Relay]: Refactor rend_service_introduce()
#6177: Refactor rend_service_introduce()
-----------------------+----------------------------------------------------
Reporter: andrea | Owner:
Type: task | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor Relay | Version:
Keywords: | Parent: #6313
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by nickm):
Just read the code and I like it so far. I think we can (and should!) add
unit tests to exercise nearly all of the new functions as a part of this
fix. Let me know if you'd like any suggestions for generating hybrid-
encrypted stuff, or what to test, etc.
Minor notes:
I think you need to add replaycache.h to noinst_HEADERS.
By convention, our foo_free() functions *always* check for NULL; there's
no need to do an additional check first if all you're doing is foo_free().
By our convention, only one-liner "ifs" with no elses get to have the
condition and the branch on the same line. Not a big deal; no need to do
a patch for this one.
In the future, it's easier for me to read squash! and fixup! commits if
the commit message describes what they do to the commit they're modifying.
I think many of the log_warn instances want to use LOG_PROTOCOL_WARN,
perhaps.
I it would be a good idea to uniformly using the name err_msg_out for a
char ** function parameter where we might stick an error. (In some
places, you're calling that "err_msg"; in some places, err_msg is a char
*).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6177#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs