[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #6232 [Analysis]: Make entropy-over-time graph



#6232: Make entropy-over-time graph
-------------------------+--------------------------------------------------
 Reporter:  arma         |          Owner:                
     Type:  enhancement  |         Status:  needs_revision
 Priority:  normal       |      Milestone:                
Component:  Analysis     |        Version:                
 Keywords:               |         Parent:                
   Points:               |   Actualpoints:                
-------------------------+--------------------------------------------------
Changes (by karsten):

  * status:  needs_review => needs_revision


Comment:

 Neat!  I took a quick look at your branch and plan to take a closer look
 tomorrow.  But for now, I have two comments:

  - The stem sources shouldn't be checked into the metrics-tasks
 repository.  Can you remove the commit adding stem and replace it with
 instructions for including stem's sources?

  - The parsing code for Wed, Wee, etc. is a rather dirty hack, because it
 depends on the position of weights in the line.  I'm not even sure if
 weights have been added in the past years, so this is very likely to
 break.

 As I said, I'm going to do a more detailed review tomorrow, and then I'll
 run your code on a few gigs of data.  Looking forward to that! :)  Thanks!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6232#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs