[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5040 [Tor]: Make public bridges add obfsproxy stats to their extra-info descriptors

#5040: Make public bridges add obfsproxy stats to their extra-info descriptors
------------------------------------------------------------------------------+
 Reporter:  karsten                                                           |          Owner:  asn               
     Type:  enhancement                                                       |         Status:  needs_revision    
 Priority:  normal                                                            |      Milestone:  Tor: 0.2.5.x-final
Component:  Tor                                                               |        Version:                    
 Keywords:  pt tor-bridge flashproxy SponsorL SponsorF20131101 wants-mocking  |         Parent:                    
   Points:                                                                    |   Actualpoints:                    
------------------------------------------------------------------------------+
Changes (by nickm):

  * keywords:  pt tor-bridge flashproxy SponsorL SponsorF20131101 => pt
               tor-bridge flashproxy SponsorL
               SponsorF20131101 wants-mocking
  * status:  needs_review => needs_revision


Comment:

 Notes for Nick:  I'm happy to make these changes myself before merging,
 once #8949 is merged. I'm just copying these here so I don't lose them.
   * HEY NICK! Remember that this is based on bug4773_rebase!
   * check test coverage on this.
   * connection_ext_or_handle_cmd_transport should use tor_memdup_nulterm.
   * clientmap_entries_eq should use strcmp_opt.
   * The hash function also needs to look at transport_name if that's now
 part of the key
   * There should be a clientmap_entry_free() function.
   * geoip_get_transport_history -- I'm not too happy about using intptr_t
 when accumulating results but unsigned int when formatting them.

 Notes for George:
   * What's up with the "<?\?>" string?  Shouldn't that be "<?\\?>" ?  But
 why ?\? in the first place?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5040#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs