Re: [tor-bugs] #11472 [TorBrowserButton]: Onion logo and text on about:tor page may overlap in non en-US TBBs

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#11472: Onion logo and text on about:tor page may overlap in non en-US TBBs
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  mikeperry
         Type:  defect   |     Status:  new
     Priority:  normal   |  Milestone:
    Component:           |    Version:
  TorBrowserButton       |   Keywords:  TorBrowserTeam201407,
   Resolution:           |  MikePerry201407R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by mcs):

 Replying to [comment:2 gk]:
 > Why the 7 maxTries? Is this something experience told you while testing
 all currently shipped locales? If so (and even if not so :) ) could you
 add a respective comment for later if someone is wondering about it?

 It is essentially a failsafe.  We added a comment; new commit is here:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/0fb285c3ca6b2196406084a50b11c641f2b8406e

 The comment is just before "let maxTries = 7" and it reads:
 {{{
 // Reduce font to 90% of previous size, repeating the process up to 7
 // times.  This allows for a maximum reduction to just less than 50% of
 // the original size.
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11472#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs