[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3455 [Firefox Patch Issues]: Tor Browser should set SOCKS username for a request based on first party domain

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------------------+-------------------------------------
     Reporter:  mikeperry            |      Owner:  mikeperry
         Type:  enhancement          |     Status:  needs_review
     Priority:  major                |  Milestone:  TorBrowserBundle
    Component:  Firefox Patch        |  2.3.x-stable
  Issues                             |    Version:
   Resolution:                       |   Keywords:  tbb-linkability, tbb-
Actual Points:                       |  usability, MikePerry201407R
       Points:                       |  Parent ID:  #5752
-------------------------------------+-------------------------------------

Comment (by gk):

 Replying to [comment:41 arthuredelstein]:
 > Replying to [comment:40 gk]:
 >
 > > Yeah, I definitely think this unittest needs to get fixed as well (I
 am okay doing it not in this bug but when we prepare things for Mozilla).
 Another reason for keeping the original method's name is that it is more
 specific than just "apply" giving a better context on what is going on...
 >
 > OK, I've changed the method's name back to ApplyFilter. And I updated
 the unit tests you found, since we might forget otherwise...

 Nice. But there remains quite some stuff to be done here (you know, just
 that we don't forget it :) )
 https://mxr.mozilla.org/mozilla-
 esr24/source/netwerk/test/unit/test_protocolproxyservice.js#151
 https://mxr.mozilla.org/mozilla-
 esr24/source/netwerk/test/unit/test_protocolproxyservice.js#156
 ...

 > > One thing I forgot: we probably need new IIDs as we are changing
 interfaces.
 >
 > Good point -- I've updated them. New versions of all three patches have
 been uploaded.

 Thanks! One more question: You did not update https://mxr.mozilla.org
 /mozilla-esr24/source/dom/mobilemessage/src/ril/MmsService.js because Tor
 Browser is not using that one (yet), right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:42>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs