[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12640 [Tor]: Entry guard unittest (#12207) fail in out-of-tree builds

#12640: Entry guard unittest (#12207) fail in out-of-tree builds
------------------------+--------------------------------
     Reporter:  asn     |      Owner:
         Type:  defect  |     Status:  closed
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:
   Resolution:  fixed   |   Keywords:  tor-guard
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------
Changes (by nickm):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Whoops. I checked in another fix for this before I saw your ticket.  (The
 final version was 7259e3f6049c7a644cb1c797432d29b57a.)  Your fix is pretty
 clean too.  I'm going to close this for now, but if we need to add more
 data files for use by the unit tests, let's do it your way.

 One thing that we would need to fix to solve this your way: I don't think
 it will work with Windows and Mingw.  (I tried a similar approach and
 Windows unit tests failed.) Here's what I think was happening:  Under
 mingw, doing a pwd will get you a directory with a nice name like
 /c/home/weasel/src/tor.  But when compiled program tries to open
 /c/home/weasel/{...}/test/test_descriptors.txt , it will fail, because the
 Windows open() implementation expects filenames like
 C:\home\weasel\{...}\test_descriptors.txt .  (I think it can handle the
 forward-slashes, but not the /c/.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12640#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs