[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12693 [Tor]: autoreconf 2.62 can't handle AS_VAR_IF in our configure.ac

#12693: autoreconf 2.62 can't handle AS_VAR_IF in our configure.ac
------------------------+--------------------------------
     Reporter:  arma    |      Owner:
         Type:  defect  |     Status:  new
     Priority:  normal  |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor     |    Version:  Tor: 0.2.5.2-alpha
   Resolution:          |   Keywords:
Actual Points:          |  Parent ID:
       Points:          |
------------------------+--------------------------------

Comment (by ioerror):

 Indeed - to upgrade urras to '''Tor version 0.2.6.0-alpha-dev (git-
 50390d4ae4fa83dd)''' I made a simple patch before rebuilding:

 {{{
 commit 50390d4ae4fa83dd33f6c9e9533c7ed670ca145f
 Author: Jacob Appelbaum <jacob@xxxxxxxxxxxxx>
 Date:   Wed Jul 23 23:37:27 2014 +0000

     remove AS_VAR_IF

 diff --git a/configure.ac b/configure.ac
 index 414c72a..51b62bf 100644
 --- a/configure.ac
 +++ b/configure.ac
 @@ -604,11 +604,6 @@ if test x$enable_gcc_hardening != xno; then
      TOR_CHECK_CFLAGS(-fstack-protector-all, also_link)
      AS_VAR_PUSHDEF([can_compile], [tor_cv_cflags_-fstack-protector-all])
      AS_VAR_PUSHDEF([can_link], [tor_can_link_-fstack-protector-all])
 -    AS_VAR_IF(can_compile, [yes],
 -        AS_VAR_IF(can_link, [yes],
 -                  [],
 -                  AC_MSG_ERROR([We tried to build with stack protection;
 it looks like your compiler supports it
 -        )
      AS_VAR_POPDEF([can_link])
      AS_VAR_POPDEF([can_compile])
      TOR_CHECK_CFLAGS(-Wstack-protector)

 }}}

 This is not the fix we want but it is the fix that allowed me to upgrade
 my Directory Authority when it was sorely needed. I could probably produce
 a reasonable patch but I was in a hurry. This is largely just to document
 the problem and to provide a simple solution. I think we should remove the
 need for '''AS_VAR_IF''' unless we're going to drop support for
 '''autoreconf 2.62.''' in Tor.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12693#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs