[tor-bugs] #12716 [meek]: Make meek-client-torbrower take the firefox command as a parameter

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#12716: Make meek-client-torbrower take the firefox command as a parameter
--------------------+---------------------
 Reporter:  dcf     |          Owner:  dcf
     Type:  defect  |         Status:  new
 Priority:  minor   |      Milestone:
Component:  meek    |        Version:
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
--------------------+---------------------
 meek-client-torbrowser hardcodes the firefox binary and profile paths:
 [https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/2ef6e31de94eb10d40464a38909373114ff44132:/meek-
 client-torbrowser/linux.go linux] [https://gitweb.torproject.org
 /pluggable-
 transports/meek.git/blob/2ef6e31de94eb10d40464a38909373114ff44132:/meek-
 client-torbrowser/mac.go mac] [https://gitweb.torproject.org/pluggable-
 transports/meek.git/blob/2ef6e31de94eb10d40464a38909373114ff44132:/meek-
 client-torbrowser/windows.go windows]. The problem is that when Tor
 Browser is reorganized, as it was in #11641, you need to make the
 corresponding change in meek-client-torbrowser, for example
 [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commitdiff/178572f5f1bb52200fa4c45497298241a745d8af
 178572f5].

 meek-client-torbrowser already takes the full meek-client command on the
 command line; it [https://gitweb.torproject.org/builders/tor-browser-
 bundle.git/blob/a2370de2b0b44a22f3f2591c2960cd6767940b8b:/Bundle-
 Data/PTConfigs/linux/torrc-defaults-appendix#l14 looks like]:
 {{{
 ClientTransportPlugin meek exec ./TorBrowser/Tor/PluggableTransports/meek-
 client-torbrowser -- ./TorBrowser/Tor/PluggableTransports/meek-client
 --url=https://meek-reflect.appspot.com/ --front=www.google.com
 }}}
 I don't know of a good clear way to encode two separate command lines into
 the command line of another program, except maybe to do them both as long
 strings and then parse the strings before calling exec.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12716>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs