[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3455 [Tor Browser]: Tor Browser should set SOCKS username for a request based on first party domain

#3455: Tor Browser should set SOCKS username for a request based  on first party
domain
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  mikeperry
  mikeperry              |     Status:  needs_review
         Type:           |  Milestone:  TorBrowserBundle 2.3.x-stable
  enhancement            |    Version:
     Priority:  major    |   Keywords:  tbb-linkability, tbb-usability,
    Component:  Tor      |  MikePerry201407R, tbb-firefox-patch
  Browser                |  Parent ID:  #5752
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by arthuredelstein):

 Replying to [comment:46 gk]:

 Thanks for looking it over!

 > 1) "The filterFunction should expect two arguments:
 filterFunction(aChannel, aProxy)": you probably just meant `aChannel` and
 `aProxy` being those arguments.

 Fixed that.

 > 2) "Returns a zero-argument function that will unregister the filter.":
 I wonder where this is going to happen? I think you can omit that as
 according to MDN:
 > {{{
 > All filters will be automatically unregistered at XPCOM shutdown.
 > }}}

 Good point. I've removed that code.

 > That said, what I like to see getting unregistered/removed on shutdown
 are observers although I realize that the common style in Torbutton seems
 to be ignoring this thing... :) So, feel free to keep the observer for
 profile-after-change as-is.

 OK, I'll leave it for now. Maybe at some point we can revisit shutdown
 handling for all observers.

 I've made a couple of additional minor changes to comments, and changed
 some vars to lets.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3455#comment:47>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs