[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #16467 [Tor]: Faster Ed25519 implementation.

#16467: Faster Ed25519 implementation.
-----------------------------+------------------------------------
     Reporter:  yawning      |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor          |    Version:  Tor: 0.2.7
   Resolution:               |   Keywords:  performance, tor-relay
Actual Points:               |  Parent ID:  #9663
       Points:               |
-----------------------------+------------------------------------

Comment (by yawning):

 Replying to [comment:18 teor]:
 > They'd be most helpful in each function, where the errors are logged by
 clang sanitizer.

 I'm now confused as to which functions exactly produce the errors,
 possibly because I moved code around etc.  Additionally, I'm not exactly
 sure if I buy the explanation that Clang wants a `strlen`, since assuming
 `unsigned char *` is a NUL-terminated string seems like a rather poor
 assumption to be making in the first place.

 I'm going to leave things as is, we can always add comments later as
 needed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16467#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs